Skip to content

Fix Model.bulkWrite sorting #16080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkarpov15 merged 2 commits into from
Mar 10, 2026
+47 −1
Merged

Fix Model.bulkWrite sorting #16080

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e0590
Fix Model.bulkWrite sorting
pnkov Mar 10, 2026
e8e7f60
Add tests for gh-16079
pnkov Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3432,7 +3432,7 @@ Model.bulkWrite = async function bulkWrite(ops, options) {
sort((v1, v2) => v1.index - v2.index).
map(v => v.error);

const validOps = validOpIndexes.sort().map(index => ops[index]);
const validOps = validOpIndexes.sort((a, b) => a - b).map(index => ops[index]);

if (validOps.length === 0) {
if (options.throwOnValidationError && validationErrors.length) {
Expand Down