fix(model): handle passing string projection to hydrate()#16088
Open
fix(model): handle passing string projection to hydrate()#16088
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Model.hydrate() runtime handling for projection when passed as a string or string[], aligning behavior with the documented/typed API and preventing incorrect projection application.
Changes:
- Normalize
hydrate()’sprojectionusingparseProjection()before applying it. - Expand
hydrate()projection tests to cover object, string (exclusive), andstring[](inclusive) forms. - Minor refactor in
parseProjection()implementation (charAt()/slice()).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/model.js |
Parses projection in Model.hydrate() to correctly support string / string-array projections before applyProjection() and model creation. |
test/model.hydrate.test.js |
Adds coverage ensuring hydrate() respects object, string, and string[] projection inputs without marking docs modified. |
lib/helpers/projection/parseProjection.js |
Small internal implementation tweak used by hydrate() to convert string/array projections to an object form. |
AbdelrahmanHafez
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16082
Summary
Quick fix for
Model.hydrate(): useparseProjection()with noretainMinusPathsto handle string and array of string projections. Both docs and TypeScript types indicateModel.hydrate()supportsstring|string[]as projection argument, so runtime should support that too.Examples