feat: Add My Account button block #400
Merged
laurelfulford merged 13 commits intotrunkfrom Jan 29, 2026
Merged
Conversation
6 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds styling and configuration for a new "My Account" button block that integrates with Newspack's Reader Activation feature. The block is conditionally displayed in the header when Reader Activation is enabled.
Changes:
- Added block styling configuration in theme.json for the newspack/my-account-button block
- Created SCSS styles for the button with small size and outline variants
- Updated header-desktop-style-1 pattern to include the my-account button alongside the Donate button
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| theme.json | Adds block-level styling configuration for the my-account-button including colors, spacing, typography, and border radius |
| src/scss/blocks/newspack/_my-account-button.scss | Defines SCSS styles for small size variant and outline style of the my-account button |
| src/scss/blocks/_blocks.scss | Imports the new my-account-button SCSS file |
| patterns/header/header-desktop-style-1.php | Updates header pattern to wrap Donate button and add conditional my-account button when Reader Activation is enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Pushed some changes, related to Automattic/newspack-plugin#4409 (comment) |
rbcorrales
approved these changes
Jan 26, 2026
rbcorrales
reviewed
Jan 26, 2026
|
|
||
| ?> | ||
| <!-- wp:group {"lock":{"move":true,"remove":true},"metadata":{"name":"<?php esc_html_e( 'Header (Desktop)', 'newspack-block-theme' ); ?>"},"style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"0","right":"var:preset|spacing|30","left":"var:preset|spacing|30"},"blockGap":"var:preset|spacing|30","margin":{"bottom":"var:preset|spacing|80"}}},"backgroundColor":"base","layout":{"type":"constrained"}} --> | ||
| <!-- wp:group {"lock":{"move":true,"remove":true},"metadata":{"name":"Header (Desktop)"},"style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"0","right":"var:preset|spacing|30","left":"var:preset|spacing|30"},"blockGap":"var:preset|spacing|30","margin":{"bottom":"var:preset|spacing|80"}}},"backgroundColor":"base","layout":{"type":"constrained"}} --> |
Member
There was a problem hiding this comment.
Was this change in pattern strings intentional? That prevents translations.
Contributor
Author
There was a problem hiding this comment.
Eep, definitely not intentional! Reinstated in f5cc8d2.
matticbot
pushed a commit
that referenced
this pull request
Feb 5, 2026
# [1.24.0-alpha.1](v1.23.0...v1.24.0-alpha.1) (2026-02-05) ### Bug Fixes * dequeue some Woo styles from the theme ([#401](#401)) ([821f81c](821f81c)) * update single post template widths ([#407](#407)) ([a99b2cf](a99b2cf)) ### Features * Add My Account button block ([#400](#400)) ([7c99f35](7c99f35)) * add My Account button block to all header patterns ([#404](#404)) ([d7b8b4a](d7b8b4a))
|
🎉 This PR is included in version 1.24.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 16, 2026
# [1.24.0](v1.23.0...v1.24.0) (2026-02-16) ### Bug Fixes * dequeue some Woo styles from the theme ([#401](#401)) ([821f81c](821f81c)) * update single post template widths ([#407](#407)) ([a99b2cf](a99b2cf)) ### Features * Add My Account button block ([#400](#400)) ([7c99f35](7c99f35)) * add My Account button block to all header patterns ([#404](#404)) ([d7b8b4a](d7b8b4a))
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
See Automattic/newspack-plugin#4409
Closes # .
How to test the changes in this Pull Request:
Other information: