Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Playwright E2E tests to better handle “My Account” navigation on mobile and to reflect the updated subscription link label.
Changes:
- Remove the extra “Account settings” navigation step in the reader registration flow.
- Update the donations test to navigate to subscriptions via
clickMyAccountMenuItemusing the “Subscription” label.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/reader-registration.spec.ts | Removes now-unneeded “Account settings” clicks during profile updates. |
| tests/donations.spec.ts | Switches subscription navigation to clickMyAccountMenuItem and updates the link label to “Subscription”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chickenn00dle
force-pushed
the
fix/e2e-tests
branch
from
64b8823 to
fef25f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accounts for mobile my account links as well as subscription link name in donations test.
To test: