test: fix AS group references

Author: miguelpeixe

includes/reader-activation/sync/class-contact-sync.php

@@ -37,11 +37,6 @@ class Contact_Sync extends Sync {
 	 */
 	const RETRY_HOOK = 'newspack_contact_sync_retry';
 
-	/**
-	 * ActionScheduler group for integration sync retries.
-	 */
-	const RETRY_GROUP = 'newspack-contact-sync-retry';
-
 	/**
 	 * Maximum number of retries for a failed integration sync.
 	 */

tests/unit-tests/data-events.php

@@ -552,7 +552,7 @@ public function test_dispatch_via_action_scheduler() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Data_Events::DISPATCH_AS_HOOK,
-				'group'  => Data_Events::DISPATCH_AS_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'
@@ -684,7 +684,7 @@ public function test_handler_retry_scheduling() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Data_Events::HANDLER_RETRY_HOOK,
-				'group'  => Data_Events::HANDLER_RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'
@@ -716,7 +716,7 @@ public function test_closure_handler_no_retry() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Data_Events::HANDLER_RETRY_HOOK,
-				'group'  => Data_Events::HANDLER_RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'
@@ -819,7 +819,7 @@ public function test_max_retries_respected() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Data_Events::HANDLER_RETRY_HOOK,
-				'group'  => Data_Events::HANDLER_RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'

tests/unit-tests/reader-activation-sync.php

@@ -327,7 +327,7 @@ public function test_integration_retry_scheduling() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Contact_Sync::RETRY_HOOK,
-				'group'  => Contact_Sync::RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'
@@ -370,7 +370,7 @@ public function test_integration_retry_success() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Contact_Sync::RETRY_HOOK,
-				'group'  => Contact_Sync::RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'
@@ -413,7 +413,7 @@ public function test_integration_max_retries() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Contact_Sync::RETRY_HOOK,
-				'group'  => Contact_Sync::RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'
@@ -451,7 +451,7 @@ public function test_integration_retry_invalid_data() {
 		$pending = as_get_scheduled_actions(
 			[
 				'hook'   => Contact_Sync::RETRY_HOOK,
-				'group'  => Contact_Sync::RETRY_GROUP,
+				'group'  => 'newspack',
 				'status' => \ActionScheduler_Store::STATUS_PENDING,
 			],
 			'ARRAY_A'