feat(content-gate): content rules

[miguelpeixe]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Implements the gate content rules and organizes content gate components.

How to test the changes in this Pull Request:

1. Make sure you have the NEWSPACK_CONTENT_GATES constant set to true
2. Navigate to Audience -> Content Gates
3. Create a new gate
4. Add multiple access rules and content rules (make sure to include taxonomy content rules)
5. Set values for the rules and metering
6. Click Save
7. Refresh the page confirm the options persisted
8. Reorder the gates using the arrows and drag (regression test)
9. Refresh the page and confirm the order persisted

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[rbcorrales]

I'm now getting this error when trying to save, pointing to a recently updated line:

{
    "code": "qm_fatal",
    "message": "Uncaught Error: Cannot access offset of type string on string in /newspack-repos/newspack-plugin/includes/wizards/audience/class-audience-content-gates.php on line 285",
    "data": {
        "message": "Uncaught Error: Cannot access offset of type string on string",
        "file": "/newspack-repos/newspack-plugin/includes/wizards/audience/class-audience-content-gates.php",
        "line": 285,
        "trace": [
            {
                "file": "/newspack-repos/newspack-plugin/includes/wizards/audience/class-audience-content-gates.php",
                "line": 270,
                "function": "sanitize_access_rule",
                "class": "Newspack\\Audience_Content_Gates",
                "type": "->"
            },
            {
                "file": "/newspack-repos/newspack-plugin/includes/wizards/audience/class-audience-content-gates.php",
                "line": 237,
                "function": "sanitize_rules",
                "class": "Newspack\\Audience_Content_Gates",
                "type": "->"
            },
            {
                "file": "/var/www/html/wp-includes/rest-api/class-wp-rest-request.php",
                "line": 850,
                "function": "sanitize_gate",
                "class": "Newspack\\Audience_Content_Gates",
                "type": "->"
            },
...

The payload looks like this:

{
    "gate": {
        "id": 1376,
        "status": "publish",
        "title": "Another Gate",
        "description": "",
        "metering": {
            "enabled": true,
            "anonymous_count": "0",
            "registered_count": "0",
            "period": "week"
        },
        "priority": 0,
        "access_rules": [
            "automattic.com",
            {
                "slug": "email_domain",
                "value": "automattic.com"
            }
        ],
        "content_rules": [
            [
                "newspack_collection"
            ],
            {
                "slug": "post_types",
                "value": [
                    "newspack_collection"
                ]
            }
        ]
    }
}

[miguelpeixe]

Thanks, @rbcorrales!

The sanitization hooks being incorrect (not executed at all) allowed for its logic to have a lot of inconsistencies 😅

Should be good after 3d8c23c. It's best to test with a fresh gate, as the sanitizer stored an incorrect data structure.

[rbcorrales]

Thanks @miguelpeixe for addressing all the issues!

[miguelpeixe]

Thank you for the thorough review!

[github-actions]

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[matticbot]

🎉 This PR is included in version 6.28.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 6.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀