Skip to content

Conversation

@leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

A few more tweaks to handle edge cases:

  • Handle user nicenames that exceeds the allowed size (shorten them and make sure to redirect the old slug)
  • Handle email max size
  • By default, just assign the existing images as the user avatar, instead of sideloading and creating a new image in the media library for each avatar.

How to test the changes in this Pull Request:

Tested

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani requested a review from a team as a code owner November 13, 2025 13:04
@leogermani leogermani self-assigned this Nov 13, 2025
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 13, 2025
Copy link
Contributor

@jason10lee jason10lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugged in huddle with @leogermani; fix tested and committed. Good to go!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 17, 2025
@leogermani leogermani merged commit 948216d into trunk Dec 17, 2025
8 checks passed
@leogermani leogermani deleted the chore/ga-migrator-tweaks branch December 17, 2025 20:09
@github-actions
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants