Skip to content

Conversation

@dkoo
Copy link
Contributor

@dkoo dkoo commented Dec 2, 2025

See discussion in #4251. As mentioned:

  • Fixes several issues with the sanitize_gate method (UI has no expected description field, sanitize_access_rule converts an array of product IDs to strings via sanitize_text_field, etc)
  • Changes the UI element for selecting subscription products to a FormTokenField: the UI only let you choose a single value, but the back-end expects an array of values.
  • Corrects the content rule slug when evaluating the post_types rule (note plural)
  • Fixes a fatal error due to mismatched parameters from the newspack_content_gate_restrict_post filter hook in class-content-gifting.php

@dkoo dkoo requested a review from miguelpeixe December 2, 2025 23:48
@dkoo dkoo requested a review from a team as a code owner December 2, 2025 23:48
@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 3, 2025
@dkoo dkoo self-assigned this Dec 3, 2025
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing these! Just left a minor comment.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 3, 2025
@dkoo dkoo merged commit 980ac04 into feat/content-gate-restriction-rules Dec 3, 2025
8 checks passed
@dkoo dkoo deleted the feat/content-gate-restriction-rules--fixes branch December 3, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants