fix: hide 'trashed' subscriptions from My Account

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR hides trashed subscriptions from the My Account view.

If you only have trashed subscriptions, it hides the Subscriptions menu all together.

See: NPPM-2442

How to test the changes in this Pull Request:

1. Start on a test site with RAS set up
2. Set up a subscription product that can be purchased multiple times by the same reader (just to make testing easier), and add a Checkout button block
3. In an incognito window, run through a purchase of your subscription with the credit card 4000 0000 0000 0341 (which will result in a failed payment).
4. After the transaction fails, go to 'My Account', and note the trash sub:

5. Apply this PR and run npm run build.
6. In the incognito window, refresh the page; confirm you don't have any subscriptions listed, and there isn't a Subscription menu item (so the typical reader wouldn't get to this screen).

7. Go back and try to buy the subscription again, this time using a successful test card.
8. Go back to My Account, and confirm you have a single My Subscription; when you click on it it should show your one subscription details:

9. Purchase a second subscription and confirm you get the Subscriptions menu item with a list as the top level in My Account, and that only non-trashed subs are shown (you can also mess with the subscriptions, cancelling them, etc.). All of them should show, unless they are trashed:

10. Lastly, as the admin manually trash all but one subscription and make sure you're back to the view in step 8 (if you just refresh the /subscriptions page as the user, you'll still see the list with one item, but the navigation should say My Subscription and just go to the remaining non-trashed one).

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[miguelpeixe]

This tested well, but I think we can go for a simpler approach. The user subscription list and "Subscriptions/My Subscription" button rely on wcs_get_users_subscriptions(), which supports a hook.

Something like this should be enough:

add_filter(
	'wcs_get_users_subscriptions',
	function( $subscriptions ) {
		if ( function_exists( 'is_account_page' ) && is_account_page() ) {
			$subscriptions = array_filter(
				$subscriptions,
				function( $subscription ) {
					return ! $subscription->has_status( 'trash' );
				}
			);
		}
		return $subscriptions;
	},
	10
);

[laurelfulford]

Oh, that's so much nicer - thanks @miguelpeixe! 🙌

I left a couple pieces of the original code in:

• I noticed when you just had My Subscription in the menu it didn't highlight when you clicked on it, so that's been fixed
• I tweaked the styles of buttons when they're in notices to just look like regular links - they were displaying full size before and sticking out of the bottom. I only saw this kind of message + button when I visited /my-account/subscriptions/ when no subscriptions were actually showing - a reader's not going to get to that but it was bugging me 😆

[miguelpeixe]

Thank you for revising! 🙌

[github-actions]

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️