fix(my-account): top position on desktop #4355
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
laurelfulford
approved these changes
Dec 12, 2025
Contributor
laurelfulford
left a comment
laurelfulford
left a comment
There was a problem hiding this comment.
This looks good, @miguelpeixe!
This isn't introduced by this PR, but I noticed a weird edge case when you don't have a favicon set, the Home link is really close to the top - approving since it doesn't need to be fixed in this PR, but mentioning in case it's easy to sneak in 😅
github-actions
bot
added
[Status] Approved
Member
Author
|
Thank you, @laurelfulford! Filed NPPD-1060 for this edge case, good catch! |
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Jan 9, 2026
# [6.29.0-alpha.1](v6.28.0...v6.29.0-alpha.1) (2026-01-09) ### Bug Fixes * add default reader meta ([#4360](#4360)) ([01564ad](01564ad)) * **ads:** placement control value reset ([#4375](#4375)) ([72d7b68](72d7b68)) * **autocomplete:** improve value parsing in AutocompleteTokenField and ListsControl components ([#4376](#4376)) ([84e388d](84e388d)) * clarify the media credit placeholder image's labelling ([#4352](#4352)) ([4420b65](4420b65)) * **content-gating:** stop running `restrict_post` after gate is rendered ([#4368](#4368)) ([8489a6c](8489a6c)) * fallback password reset URL ([#4382](#4382)) ([06d1503](06d1503)) * hide 'trashed' subscriptions from My Account ([#4351](#4351)) ([e759378](e759378)) * **my-account:** top position on desktop ([#4355](#4355)) ([1b3255a](1b3255a)) * prevent doubled URL in reader registration block magic link ([#4379](#4379)) ([ba4d855](ba4d855)) * remove newspack-ui CSS class from my account when not logged in ([#4384](#4384)) ([2bb8630](2bb8630)) * remove space if no time ([#4380](#4380)) ([05c57e9](05c57e9)) * select specific product for content gifting and countdown banners ([#4366](#4366)) ([809c230](809c230)) * **sso:** change Jetpack configuration notice from error to warning ([#4383](#4383)) ([e5e0643](e5e0643)) * **subscriptions:** remove actions from gifted subscription ([#4362](#4362)) ([8fbc243](8fbc243)) * **update-payment-notice:** don't render on checkout ([#4356](#4356)) ([dd80c06](dd80c06)) ### Features * Add Managed Nextdoor Auth ([#4359](#4359)) ([fee2480](fee2480)) * add media credits to RSS feeds ([#4357](#4357)) ([e638447](e638447)) * **content-gating:** add Content Gate settings page ([#4363](#4363)) ([822c363](822c363)) * **content-gating:** enable content rule exclusions ([#4346](#4346)) ([1e5718b](1e5718b)) * **content-gating:** update content gates UI ([#4345](#4345)) ([4e22075](4e22075)) * rename newsletter tracking ([#4358](#4358)) ([3da6434](3da6434)) * **web-preview:** add ESC key support and dynamic titles for segments and prompts ([#4294](#4294)) ([7238d2f](7238d2f))
Contributor
|
🎉 This PR is included in version 6.29.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 19, 2026
# [6.29.0](v6.28.2...v6.29.0) (2026-01-19) ### Bug Fixes * add default reader meta ([#4360](#4360)) ([01564ad](01564ad)) * **ads:** placement control value reset ([#4375](#4375)) ([72d7b68](72d7b68)) * **autocomplete:** improve value parsing in AutocompleteTokenField and ListsControl components ([#4376](#4376)) ([84e388d](84e388d)) * clarify the media credit placeholder image's labelling ([#4352](#4352)) ([4420b65](4420b65)) * **content-gating:** stop running `restrict_post` after gate is rendered ([#4368](#4368)) ([8489a6c](8489a6c)) * fallback password reset URL ([#4382](#4382)) ([06d1503](06d1503)) * hide 'trashed' subscriptions from My Account ([#4351](#4351)) ([e759378](e759378)) * **my-account:** top position on desktop ([#4355](#4355)) ([1b3255a](1b3255a)) * prevent doubled URL in reader registration block magic link ([#4379](#4379)) ([ba4d855](ba4d855)) * remove newspack-ui CSS class from my account when not logged in ([#4384](#4384)) ([2bb8630](2bb8630)) * remove space if no time ([#4380](#4380)) ([05c57e9](05c57e9)) * select specific product for content gifting and countdown banners ([#4366](#4366)) ([809c230](809c230)) * **sso:** change Jetpack configuration notice from error to warning ([#4383](#4383)) ([e5e0643](e5e0643)) * **subscriptions:** remove actions from gifted subscription ([#4362](#4362)) ([8fbc243](8fbc243)) * **update-payment-notice:** don't render on checkout ([#4356](#4356)) ([dd80c06](dd80c06)) ### Features * Add Managed Nextdoor Auth ([#4359](#4359)) ([fee2480](fee2480)) * add media credits to RSS feeds ([#4357](#4357)) ([e638447](e638447)) * **content-gating:** add Content Gate settings page ([#4363](#4363)) ([822c363](822c363)) * **content-gating:** enable content rule exclusions ([#4346](#4346)) ([1e5718b](1e5718b)) * **content-gating:** update content gates UI ([#4345](#4345)) ([4e22075](4e22075)) * rename newsletter tracking ([#4358](#4358)) ([3da6434](3da6434)) * **web-preview:** add ESC key support and dynamic titles for segments and prompts ([#4294](#4294)) ([7238d2f](7238d2f))
Contributor
|
🎉 This PR is included in version 6.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#4303 introduced mobile improvements, but also a small regression with the navigation area position on desktop, which gets fixed by this PR.
How to test the changes in this Pull Request:
As a reader, visit the My Account page and confirm that the navigation area is attached to the top.
Other information: