Skip to content

fix(update-payment-notice): don't render on checkout #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miguelpeixe merged 1 commit into from
Dec 12, 2025
Merged

fix(update-payment-notice): don't render on checkout #4356

miguelpeixe merged 1 commit into from
Dec 12, 2025
+5 −0

Conversation

@miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Dec 11, 2025

All Submissions:

Changes proposed in this Pull Request:

NPPD-1054

Don't render the update payment notice on checkout pages:

Before After
image image

How to test the changes in this Pull Request:

  1. As a reader, purchase a subscription
  2. As an admin, edit the subscription and create a pending renewal order to trigger the payment notice
  3. Visit the homepage as a reader and confirm you get the notice
  4. Trigger a modal checkout flow via a checkout button block and confirm the notice doesn't render in the modal

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Dec 11, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner December 11, 2025 19:20
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 11, 2025
laurelfulford
laurelfulford approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 12, 2025
@miguelpeixe miguelpeixe merged commit dd80c06 into trunk Dec 12, 2025
9 checks passed
@miguelpeixe miguelpeixe deleted the fix/hide-payment-notice-from-checkout branch December 12, 2025 20:08
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Jan 9, 2026
@semantic-release-bot
chore(release): 6.29.0-alpha.1 [skip ci]
5f50c2a 
# [6.29.0-alpha.1](v6.28.0...v6.29.0-alpha.1) (2026-01-09)

### Bug Fixes

* add default reader meta ([#4360](#4360)) ([01564ad](01564ad))
* **ads:** placement control value reset ([#4375](#4375)) ([72d7b68](72d7b68))
* **autocomplete:** improve value parsing in AutocompleteTokenField and ListsControl components ([#4376](#4376)) ([84e388d](84e388d))
* clarify the media credit placeholder image's labelling ([#4352](#4352)) ([4420b65](4420b65))
* **content-gating:** stop running `restrict_post` after gate is rendered ([#4368](#4368)) ([8489a6c](8489a6c))
* fallback password reset URL ([#4382](#4382)) ([06d1503](06d1503))
* hide 'trashed' subscriptions from My Account ([#4351](#4351)) ([e759378](e759378))
* **my-account:** top position on desktop ([#4355](#4355)) ([1b3255a](1b3255a))
* prevent doubled URL in reader registration block magic link ([#4379](#4379)) ([ba4d855](ba4d855))
* remove newspack-ui CSS class from my account when not logged in ([#4384](#4384)) ([2bb8630](2bb8630))
* remove space if no time ([#4380](#4380)) ([05c57e9](05c57e9))
* select specific product for content gifting and countdown banners ([#4366](#4366)) ([809c230](809c230))
* **sso:** change Jetpack configuration notice from error to warning ([#4383](#4383)) ([e5e0643](e5e0643))
* **subscriptions:** remove actions from gifted subscription ([#4362](#4362)) ([8fbc243](8fbc243))
* **update-payment-notice:** don't render on checkout ([#4356](#4356)) ([dd80c06](dd80c06))

### Features

* Add Managed Nextdoor Auth ([#4359](#4359)) ([fee2480](fee2480))
* add media credits to RSS feeds ([#4357](#4357)) ([e638447](e638447))
* **content-gating:** add Content Gate settings page ([#4363](#4363)) ([822c363](822c363))
* **content-gating:** enable content rule exclusions ([#4346](#4346)) ([1e5718b](1e5718b))
* **content-gating:** update content gates UI ([#4345](#4345)) ([4e22075](4e22075))
* rename newsletter tracking ([#4358](#4358)) ([3da6434](3da6434))
* **web-preview:** add ESC key support and dynamic titles for segments and prompts ([#4294](#4294)) ([7238d2f](7238d2f))
@matticbot
Copy link
Contributor

matticbot commented Jan 9, 2026

🎉 This PR is included in version 6.29.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@miguelpeixe miguelpeixe

Labels

released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miguelpeixe @matticbot @laurelfulford