Skip to content

Conversation

@leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

When Woo creates a user as part of a flow, for example gifting a subscription, it was not adding RAS specific metadata.

This PR assumes that any programatically created user via Woo's method is a user without a password and unverified.

(Note: It's known that when a reader registers it will trigger the new callback twice (via hook and via the reader_register method). I think that's fine).

How to test the changes in this Pull Request:

  1. Create a giftable subscription
  2. As a user, purchase this product as a gift
  3. Check the email received by the gift recipient and visit my account
  4. Try to login as a gift recipient and confirm you are not asked for a password. OTP is the default login strategy

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani requested a review from a team as a code owner December 12, 2025 19:48
@leogermani leogermani self-assigned this Dec 12, 2025
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 12, 2025
@leogermani leogermani changed the title fix: add default reader meta fix: add default reader meta - NPPM-2440 Dec 12, 2025
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 16, 2025
@leogermani leogermani merged commit 01564ad into trunk Dec 17, 2025
9 checks passed
@leogermani leogermani deleted the fix/add-default-reader-meta branch December 17, 2025 13:47
@github-actions
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants