Skip to content

fix(indesign-exporter): caption and credit character encoding #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelpeixe merged 2 commits into from
Dec 16, 2025
Merged

fix(indesign-exporter): caption and credit character encoding #4364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ce549
fix(indesign-exporter): caption and credit character encoding
miguelpeixe Dec 16, 2025
cc5df4f
test: image caption and credit special characters
miguelpeixe Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/optional-modules/indesign-export/class-indesign-converter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,10 @@ private function process_post_images( $post ) {

$tag_content .= "\r\n";
if ( $caption ) {
$tag_content .= '<pstyle:PhotoCaption>' . $caption . "\r\n";
$tag_content .= '<pstyle:PhotoCaption>' . $this->get_transformed_text( $caption ) . "\r\n";
}
if ( $credit ) {
$tag_content .= '<pstyle:PhotoCredit>' . $credit . "\r\n";
$tag_content .= '<pstyle:PhotoCredit>' . $this->get_transformed_text( $credit ) . "\r\n";
}
}

Expand Down
26 changes: 26 additions & 0 deletions tests/unit-tests/indesign-exporter/indesign-exporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,30 @@ public function test_convert_horizontal_rule() {
$content = $converter->convert_post( $post_id );
$this->assertStringContainsString( '<pstyle:hr>', $content );
}

/**
* Test image caption and credit special characters.
*/
public function test_image_caption_and_credit_special_characters() {
$image_id = $this->factory->attachment->create();
wp_update_post(
[
'ID' => $image_id,
'post_excerpt' => 'Image Caption with á é í ó ú ñ ç ð ð &nbsp;, &amp;, &lt;, &gt; and •.',
]
);
update_post_meta( $image_id, '_media_credit', 'Image Credit with á é í ó ú ñ ç ð ð &nbsp;, &amp;, &lt;, &gt; and •.' );

$post_id = $this->factory->post->create(
[
'post_title' => 'Test Post',
'post_content' => '<!-- wp:image {"id":' . $image_id . '} --><figure class="wp-block-image"><img src="http://localhost/wp-content/uploads/2025/01/image.jpg" /><figcaption class="wp-element-caption">Image Caption with á é í ó ú ñ ç ð ð &nbsp;, &amp;, &lt;, &gt; and •.</figcaption></figure><!-- /wp:image -->',
]
);

$converter = new InDesign_Converter();
$content = $converter->convert_post( $post_id );
$this->assertStringContainsString( '<pstyle:PhotoCaption>Image Caption with <0x00E1> <0x00E9> <0x00ED> <0x00F3> <0x00FA> <0x00F1> <0x00E7> <0x00F0> <0x00F0> , &, <, > and <CharStyle:bullet>n<CharStyle:>.', $content );
$this->assertStringContainsString( '<pstyle:PhotoCredit>Image Credit with <0x00E1> <0x00E9> <0x00ED> <0x00F3> <0x00FA> <0x00F1> <0x00E7> <0x00F0> <0x00F0> , &, <, > and <CharStyle:bullet>n<CharStyle:>.', $content );
}
}