Skip to content

Conversation

@laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Updates the Data Events Readme as part of Automattic/newspack-popups#1509

This should be tested as part of Automattic/newspack-popups#1509 only because it shouldn't be merged until all of those changes are deemed okay.

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford marked this pull request as ready for review January 6, 2026 22:35
@laurelfulford laurelfulford requested a review from a team as a code owner January 6, 2026 22:35
@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 6, 2026
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 7, 2026
@laurelfulford laurelfulford merged commit 57cb730 into trunk Jan 9, 2026
9 checks passed
@laurelfulford laurelfulford deleted the fix/rename-prompt-id-to-newspack-popup-id branch January 9, 2026 21:14
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants