Skip to content

Conversation

@miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

NPPM-2463

If Emails::get_password_reset_url() gets called without Woo active, it'll fallback to core's wp_lostpassword_url(). This will redirect to a page that resends the email that the user just received.

This PR resolves the issue by adding the required parameters, allowing the password to be reset in the next step.

How to test the changes in this Pull Request:

  1. With RAS active, deactivate Woo (wp plugin deactivate woocommerce-subscriptions woocommerce)
  2. While on trunk, visit wp-login.php and go through the password recovery flow for a reader account
  3. Confirm you get an email with the link, and the link redirects to the same page
  4. Checkout this branch and request another password recovery
  5. Confirm the link redirects you to set the new password
  6. Confirm the password is updated

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Jan 7, 2026
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 7, 2026 14:24
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 7, 2026
Copy link
Member

@rbcorrales rbcorrales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the reset flow with Woo deactivated and received the correct link in the email after your changes.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 7, 2026
@miguelpeixe miguelpeixe merged commit 06d1503 into trunk Jan 8, 2026
9 checks passed
@miguelpeixe miguelpeixe deleted the fix/password-reset-url-fallback branch January 8, 2026 12:47
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants