Skip to content

fix(sso): change Jetpack configuration notice from error to warning #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelpeixe merged 2 commits into from
Jan 8, 2026
Merged

fix(sso): change Jetpack configuration notice from error to warning #4383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d1570d
fix(sso): change Jetpack configuration notice from error to warning
miguelpeixe Jan 7, 2026
6c04517
feat: external link to jetpack
miguelpeixe Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/wizards/newspack/views/settings/connections/jetpack-sso.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { BaseControl, CheckboxControl } from '@wordpress/components';
import { BaseControl, CheckboxControl, ExternalLink } from '@wordpress/components';
import { useEffect, useState } from '@wordpress/element';
import apiFetch from '@wordpress/api-fetch';

Expand Down Expand Up @@ -63,13 +63,9 @@ const JetpackSSO = () => {
<ActionCard
isMedium
title={ __( 'Force two-factor authentication', 'newspack-plugin' ) }
description={ () => (
<>
{ __(
'Improve security by requiring two-factor authentication via WordPress.com for users with higher capabilities.',
'newspack-plugin'
) }
</>
description={ __(
'Improve security by requiring two-factor authentication via WordPress.com for users with higher capabilities.',
'newspack-plugin'
) }
hasGreyHeader={ !! settings.force_2fa }
toggleChecked={ !! settings.force_2fa }
Expand All @@ -92,16 +88,18 @@ const JetpackSSO = () => {
{ error && <Notice isError noticeText={ error } /> }
{ settings.jetpack_sso_force_2fa && (
<>
<Notice
isError
noticeText={ __(
<Notice isWarning>
{ __(
'Two-factor authentication is currently enforced for all users via Jetpack configuration.',
'newspack-plugin'
) }
/>
) }{ ' ' }
<ExternalLink href="/wp-admin/admin.php?page=jetpack#/settings">
{ __( 'Jetpack Settings', 'newspack-plugin' ) }
</ExternalLink>
</Notice>
<p>
{ __(
'Customize which capabilties to enforce 2FA by untoggling the “Require accounts to use WordPress.com Two-Step Authentication” option in Jetpack settings.',
'Customize which capabilities to enforce 2FA by untoggling the “Require accounts to use WordPress.com Two-Step Authentication” option in Jetpack settings.',
'newspack-plugin'
) }
</p>
Expand Down