Skip to content

fix(content-gate): prevent metering from bypassing account verification requirement #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelpeixe merged 2 commits into from
Feb 10, 2026
+579 −2
Merged

fix(content-gate): prevent metering from bypassing account verification requirement #4459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac43ea9
fix(content-gate): prevent metering from bypassing account verificati…
miguelpeixe Feb 5, 2026
7c59d3c
fix: check reader and add tests
miguelpeixe Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions includes/content-gate/class-content-gate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,21 @@ public static function get_registration_settings( $gate_id ) {
];
}

/**
* Whether the gate requires account verification.
*
* @param int $gate_id Optional gate ID. Default is the current gate.
*
* @return bool Whether the gate requires account verification.
*/
public static function requires_account_verification( $gate_id = null ) {
if ( ! $gate_id ) {
$gate_id = self::get_gate_post_id();
}
$registration = self::get_registration_settings( $gate_id );
return $registration['require_verification'];
}

/**
* Update registration settings for a gate.
*
Expand Down
7 changes: 5 additions & 2 deletions includes/content-gate/class-metering.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,14 +361,18 @@ public static function is_logged_in_metering_allowed( $post_id = null ) {
return false;
}

// Bail if the gate requires account verification and the user is not verified.
if ( Content_Gate::requires_account_verification() && ! Reader_Activation::is_reader_verified( \wp_get_current_user() ) ) {
return false;
}

// Not in checkout modals.
if ( method_exists( 'Newspack_Blocks\Modal_Checkout', 'is_modal_checkout' ) && \Newspack_Blocks\Modal_Checkout::is_modal_checkout() ) {
return false;
}

$gate_post_id = Content_Gate::get_gate_post_id();
$settings = self::get_registered_settings( $gate_post_id );
$priority = \get_post_meta( $gate_post_id, 'gate_priority', true );

// Bail if metering is not enabled.
if ( ! $settings['enabled'] || $settings['count'] <= 0 ) {
Expand All @@ -380,7 +384,6 @@ public static function is_logged_in_metering_allowed( $post_id = null ) {
return self::$logged_in_metering_cache[ $post_id ];
}

// Aggregate metering by gate priority, if available.
$user_meta_key = self::METERING_META_KEY . '_' . $gate_post_id;

$updated_user_data = false;
Expand Down
Loading