feat(newspack-components): add divider component#4462
Conversation
18bbc95 to
f4e5e5f
Compare
There was a problem hiding this comment.
The 100vw width doesn't work when it's used inside a container-type element:
We could add an exception for when it's inside a newspack-card element with borders, but I'm not sure that would catch all instances like this. IMO full-width shouldn't be the default alignment.
Also, React recommends using function-style components over class-style components, so I refactored this to a function-style component in 37f3897.
d141731 to
c58758a
Compare
|
Hey @thomasguillot, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
* feat: add separator component * refactor: use function-type component syntax * feat(separator): update defaults * feat(separator): rename component --------- Co-authored-by: dkoo <derrick.koo@automattic.com>
All Submissions:
Changes proposed in this Pull Request:
This PR adds a new component:
Divider. I added a readme to explain how to use this in the future.How to test the changes in this Pull Request:
Other information: