You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes an issue caught in #3718 with the application of the Up Next snapshot.
When we call PlaybackManager.shared.addToUpNext, the ``UpNextButton.episodeAddedis triggered, causing animations to stack up. Instead, we should usebulkAdd` to apply the snapshot so that we don't trigger those animations.
To test
Create an Up Next queue with hundreds of episodes (>500) by selecting all from various podcasts and adding
Clear the Up Next queue
Go to Profile > Settings > Up Next History
Apply an Up Next history snapshot
✅ Ensure episodes are added to Up Next queue and results are applied instantly
Checklist
I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
I have considered adding unit tests for my changes.
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.
Version 8.8 has now entered code-freeze, so the milestone of this PR has been updated to 8.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue caught in #3718 with the application of the Up Next snapshot.
When we call
PlaybackManager.shared.addToUpNext, the ``UpNextButton.episodeAddedis triggered, causing animations to stack up. Instead, we should usebulkAdd` to apply the snapshot so that we don't trigger those animations.To test
Checklist
CHANGELOG.mdif necessary.