Fix reports screen times out on larger sites#7859
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes a slow query on the Sensei LMS reports screen that was causing timeouts on larger sites. The optimization converts a correlated subquery into a LEFT JOIN with GROUP BY, which significantly improves query performance by eliminating the need to execute the subquery for each user row.
Key Changes:
- Replaced a correlated subquery with a LEFT JOIN to fetch last activity dates more efficiently
- Removed the USE INDEX hint that is no longer needed with the new query structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/reports/overview/data-provider/class-sensei-reports-overview-data-provider-students.php | Refactored the SQL query to use LEFT JOIN instead of a correlated subquery for better performance |
| changelog/fix-slow-query-on-reports-screen | Added changelog entry documenting the query optimization fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...udes/reports/overview/data-provider/class-sensei-reports-overview-data-provider-students.php
Show resolved
Hide resolved
Member
Author
|
@donnapep, if you have the opportunity, could you please give this one a look? 🙏 |
Member
Author
|
It was confirmed that this is fixed. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7857
Resolves SEN-23
Probably resolves #4962
Relates to #7858
Proposed Changes
Testing Instructions
trunk.trunkPre-Merge Checklist