Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical error that occurred when activating the MailPoet plugin while Sensei LMS is active. The fix defers MailPoet integration initialization to the mailpoet_initialized action hook instead of attempting immediate initialization.
- Moves MailPoet API initialization from
initialize_global_objects()to a newinitialize_mailpoet()method - Registers the new method as a callback for the
mailpoet_initializedaction hook - Prevents initialization timing conflicts during plugin activation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| includes/class-sensei.php | Defers MailPoet integration initialization to the mailpoet_initialized hook to prevent activation errors |
| changelog/fix-mailpoet-error-on-plugin-activation | Documents the bug fix in the changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SEN-26
Proposed Changes
mailpoet_initializedhook.Testing Instructions
Pre-Merge Checklist