Allow multiple choice quiz questions with no wrong answers#7872
Merged
Allow multiple choice quiz questions with no wrong answers#7872
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the quiz validation logic to allow multiple choice questions where all answers are correct (i.e., no wrong answers). Previously, the system required at least one wrong answer for a question to be considered complete.
- Updated validation logic in
is_multiple_choice_question_complete()to make wrong answers optional - Added comprehensive test coverage for the new behavior
- Improved code robustness by ensuring
$wrong_answersis always an array before merging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| includes/class-sensei-quiz.php | Modified validation logic to allow multiple choice questions with only correct answers by removing the requirement for at least one wrong answer and ensuring wrong_answers is properly handled as an array |
| tests/unit-tests/test-class-quiz.php | Added comprehensive test case to verify that questions with all correct answers are not filtered out and are properly displayed on the frontend |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7868.
Proposed Changes
This updates the logic such that a multiple choice question is allowed to have no wrong answers. Previously, the logic prevented this.
Determining whether to have questions with no wrong answer is best left to a teacher to decide what makes the most sense for their content, not enforced as a technical constraint.
Testing Instructions
Pre-Merge Checklist