Remove "new" badge from Appearance settings tab#7874
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the "new" badge from the Appearance settings tab in Sensei LMS, as the Learning Mode feature is no longer considered new.
- Removes badge property from appearance-settings section definition
- Removes badge rendering logic from settings tabs display
- Removes associated CSS styling for settings tab badges
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| includes/class-sensei-settings.php | Removes the 'badge' property from the appearance-settings section array |
| includes/class-sensei-settings-api.php | Removes badge handling logic from settings_tabs() method including badge property assignment and HTML rendering |
| changelog/remove-new-label-appearance-settings | Adds changelog entry documenting the removal of the badge as a minor, removed-type change |
| assets/css/settings.scss | Removes the .sensei-settings-tab__badge CSS class and its styling rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Merging as test failures are unrelated to these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removes the "new" badge that appeared beside the Appearance tab of Sensei's settings. Learning Mode isn't that new anymore.
Testing Instructions
Pre-Merge Checklist