Skip to content

Use quiz submission repository on grading detail page #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donnapep merged 4 commits into from
Mar 31, 2026
+7 −10
Merged

Use quiz submission repository on grading detail page #7928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2cf872
Use quiz submission repository for grade on grading detail page
donnapep Mar 31, 2026
862be43
Add changelog entry for quiz grading detail page HPPS fix
donnapep Mar 31, 2026
959f451
Change changelog significance to minor
donnapep Mar 31, 2026
69c5d7e
Preserve question order in tables-based get_question_ids
donnapep Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/add-quiz-grading-hpps-integration
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: fixed

Use quiz submission repository on grading detail page for HPPS compatibility.
11 changes: 2 additions & 9 deletions includes/class-sensei-grading-user-quiz.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,8 @@ public function display() {
<div class="clear"></div><br/>
<?php

$lesson_status_id = Sensei_Utils::sensei_get_activity_value(
array(
'post_id' => $this->lesson_id,
'user_id' => $this->user_id,
'type' => 'sensei_lesson_status',
'field' => 'comment_ID',
)
);
$user_quiz_grade = get_comment_meta( $lesson_status_id, 'grade', true );
$submission = Sensei()->quiz_submission_repository->get( $this->quiz_id, $this->user_id );
$user_quiz_grade = $submission ? $submission->get_final_grade() : '';

foreach ( $questions as $question ) {
$question_id = $question->ID;
Expand Down
2 changes: 1 addition & 1 deletion ...rnal/quiz-submission/submission/repositories/class-tables-based-submission-repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ public function get_question_ids( int $submission_id ): array {

$query = $this->wpdb->prepare(
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
"SELECT question_id FROM {$quiz_answers_table} WHERE submission_id = %d",
"SELECT question_id FROM {$quiz_answers_table} WHERE submission_id = %d ORDER BY id ASC",
$submission_id
);

Expand Down
Loading