-
Notifications
You must be signed in to change notification settings - Fork 313
Update libraries and fix crashes #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a2dd907
updated most compose and kotlin libraries to latest
mzorz 29f865a
fixed inflation crash on notes list activity by using the right theme…
mzorz b93a823
removed empty tags and fixed namespaces
mzorz 1c532e8
solves a NPE after updating dependencies in which this method gets ca…
mzorz 170b5c1
fixed test
mzorz 891f3db
added @SuppressLint(RestrictedApi) on FingerprintManager API for now,…
mzorz 849c77a
- added support for JAVA_VERSION 11
mzorz 28c7b25
resolving query params in deep links into the app since it's not supp…
mzorz 22fefde
fixed backPressed behavior
mzorz 175490c
fixed lint error using appTint
mzorz fbf7b21
updated gradle to 8.14.3 using the 8.14.3 instructions https://docs.g…
mzorz 8c792b4
Root Cause Analysis
mzorz 2589709
just launch the app on account reset deeplink, redirect queryparam wa…
mzorz 9229a7a
removed jcenter() in favor of mavenCentral()
mzorz 6f51438
bumped java version 21
mzorz e9447a5
removed testInstrumentationRunner decl
mzorz 7a4fb34
minor identation nit
mzorz daae06d
using -all gradle distribution
mzorz 3616f1a
issuing testDebugUnitTest for CI, removed that build flavor which was…
mzorz 0448e63
removed proguard instructions
mzorz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 17.0 | ||
| 21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| package org.wordpress.passcodelock; | ||
|
|
||
| import android.annotation.SuppressLint; | ||
| import android.app.Activity; | ||
| import android.content.pm.ActivityInfo; | ||
| import android.os.Bundle; | ||
|
|
@@ -24,9 +25,11 @@ public abstract class AbstractPasscodeKeyboardActivity extends Activity { | |
| protected InputFilter[] filters = null; | ||
| protected TextView topMessage = null; | ||
|
|
||
| @SuppressLint("RestrictedApi") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this to avoid linter complaining for now, but tracking separately here #1734 |
||
| protected FingerprintManagerCompat mFingerprintManager; | ||
| protected CancellationSignal mCancel; | ||
|
|
||
| @SuppressLint("RestrictedApi") | ||
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
|
|
@@ -36,21 +39,21 @@ protected void onCreate(Bundle savedInstanceState) { | |
| } | ||
|
|
||
| setContentView(R.layout.app_passcode_keyboard); | ||
|
|
||
| topMessage = (TextView) findViewById(R.id.passcodelock_prompt); | ||
|
|
||
| Bundle extras = getIntent().getExtras(); | ||
| if (extras != null) { | ||
| String message = extras.getString(KEY_MESSAGE); | ||
| if (message != null) { | ||
| topMessage.setText(message); | ||
| } | ||
| } | ||
|
|
||
| filters = new InputFilter[2]; | ||
| filters[0]= new InputFilter.LengthFilter(1); | ||
| filters[1] = onlyNumber; | ||
|
|
||
| mPinCodeField = (EditText)findViewById(R.id.pin_field); | ||
|
|
||
| //setup the keyboard | ||
|
|
@@ -158,8 +161,9 @@ public void run() { | |
| protected void showPasswordError(){ | ||
| Toast.makeText(AbstractPasscodeKeyboardActivity.this, R.string.passcode_wrong_passcode, Toast.LENGTH_SHORT).show(); | ||
| } | ||
|
|
||
| protected abstract void onPinLockInserted(); | ||
| @SuppressLint("RestrictedApi") | ||
| protected abstract FingerprintManagerCompat.AuthenticationCallback getFingerprintCallback(); | ||
|
|
||
| private InputFilter onlyNumber = new InputFilter() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.