[Tooling] Use Release Version from ReleasesV2 in Code Freeze #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
tooling
Collaborator
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
Contributor
|
I have the same feedback as https://github.com/bloom/DayOne-Android/pull/6612#pullrequestreview-3319847686, and given there's a batch of those PRs across repos, so let's focus the code review feedback on that single DOAndroid PR to avoid spreading the discussions, and merge the various repo's PRs all at once once the feedback have been addressed across all of them :) |
AliSoftware
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AINFRA-1381: SNAndroid: Validate that release version sent by ReleasesV2 matches the project
Description
This PR updates the code freeze process to use the release version provided by ReleasesV2 as the source of truth.
The code freeze Buildkite pipeline now passes the
RELEASE_VERSIONenvironment variable to thestart_code_freezeFastlane lane.If there's a mismatch between the passed version and the project calculated version, a warning is displayed to help identify configuration discrepancies, but the ReleasesV2 version is always used.
Testing
The code freeze lane has several side effects like potentially changing the version in the main branch, creating a release branch, updating release notes, etc, making it hard to easily test it. We can run a couple of tests locally commenting out parts of the lane, but they'll only test a minor part of the lane.
The changes will then be fully tested in the next release cycle during code freeze.