-
Notifications
You must be signed in to change notification settings - Fork 51
Studio: Update Studio deeplink URL scheme from wpcom-local-dev to wp-studio
#2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
wpcom-local-dev to wp-studio
gcsecsey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📊 Performance Test ResultsComparing 8626060 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gavande1! I have tested it, and I can see that the new protocol prefix is being used successfully. LGTM! ![]()
| OAuth | After |
|---|---|
![]() |
![]() |
ivan-ottinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, Rahul! The change looks good. I think we could also update other occurrences of wpcom-local-dev in the codebase - e.g. in the related tests and docs.
|
One more thing: Maybe I missed it somewhere in other discussions, but what about the |
@ivan-ottinger, Yes. I am planning to address it in a separate PR. I am working on it right now. I will raise the PR soon. |
f89f709 to
2ca248c
Compare




Related issues
Proposed Changes
wpcom-local-dev://towp-studio://.Testing Instructions
npm startPre-merge Checklist