-
Notifications
You must be signed in to change notification settings - Fork 54
Remove PHP-WASM dependencies from Studio #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/studio-cli-i2
Are you sure you want to change the base?
Conversation
|
Let's remove the |
epeicher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bcotrim for this huge reduction in size 🙌
I have done some initial testing, and I have identified that creating a site does not start it for me. Also, when deleting it, an error is displayed, although the deletion completes. Please see a video below.
CleanShot.2026-01-08.at.17.08.23.mp4
Please let me know if you need the logs.
|
@epeicher |
@bcotrim, I have been investigating more, and I have done the following that fix my issues:
That fixes all the issues I was having, I am going to do some additional testing, but this looks good so far 🥳 |
epeicher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @bcotrim for these massive changes. I have done a round of testing, and these are my findings.
- Create a new site - verify it works - ✅
This works fine, I have identified a minor issue that I am not able to reproduce intrunkbut it is not a blocker, and it could be tackled as a follow-up if required. When creating a site, there is a moment where the list of sites displays the new one duplicated, please see screenshot:
- Start/stop sites - verify server operations work - ✅
- Export a site - verify backup works - ✅
- Import a site - verify restore works - ❌
Importing a recently exported backup fails with the errorDatabase import failed- Please find error logs here 3a0e9-pb - Run tests:
npm test- ✅ - Build installer:
npm run package- verify app.asar is ~295 MB - ✅ -294M Jan 9 13:15 app.asar(in trunk it occupies 1.4G 🤯 )
I have measured the time it takes to create a site (approximately), and I have observed that on my Mac, it takes around 16 seconds on trunk (using npm startand having a few sites) and it takes around 8 seconds on this branch, so this is a great improvement 🙌
All in all, I would like to have another pair of eyes to review the changes, but this is looking great, amazing work.
Related issues
Proposed Changes
Remove PHP-WASM packages (~1.1 GB) from the desktop app's ASAR bundle. The desktop app now uses CLI for all WordPress operations, making these dependencies redundant.
common/types/php-versions.ts) to replace@php-wasm/universalimportssrc/lib/wordpress-provider/)getProviderConstantsIPC/Redux layer - components import directly fromcommon/constantssrc/lib/download-utils.tsvendor/wp-now/directoryforge.config.tsignore patterns to exclude PHP-WASM from bundleSize reduction:
Testing Instructions
npm installnpm startnpm testnpm run package- verify app.asar is ~295 MBPre-merge Checklist