CLI: Refine site stop --all implementation
#2374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekelund
changed the base branch from
moveCliStopAllToStopCommandWithAllFlag
to
dev/studio-cli-i2
bcotrim
approved these changes
Jan 9, 2026
Contributor
bcotrim
left a comment
bcotrim
left a comment
There was a problem hiding this comment.
LGTM and works as described 👍
Added a couple of smaller comments, but no blockers
cli/commands/site/stop.ts
Outdated
| if ( ! runningProcess ) { | ||
| logger.reportSuccess( __( 'WordPress site is not running' ) ); | ||
| return; | ||
| const SITES_TO_TARGET: SiteData[] = []; |
Contributor
There was a problem hiding this comment.
Nit: Should we rename it to sitesToTarget?
cli/commands/site/stop.ts
Outdated
| ); | ||
| } else { | ||
| throw new LoggerError( | ||
| sprintf( __( 'Stopped %d sites out of %d' ), stoppedSiteIds.length, SITES_TO_TARGET.length ) |
Contributor
There was a problem hiding this comment.
Nit: Should we handle single site error message differently?
Stopped 0 sites out of 1 seems strange.
gcsecsey
approved these changes
Jan 9, 2026
Contributor
gcsecsey
left a comment
gcsecsey
left a comment
There was a problem hiding this comment.
The changes LGTM, and everything worked well while testing. 👍
I added the two sites:
gcsecsey@Mac-Studio studio % node dist/cli/main.js site list
✔ Found 2 sites
✔ Connected to process daemon
┌─────────────┬──────────────────────────┬────────────────────────────────────────┬─────────────────────────────────────────────────────┐
│ Status │ Name │ Path │ URL │
├─────────────┼──────────────────────────┼────────────────────────────────────────┼─────────────────────────────────────────────────────┤
│ 🟢 Online │ site-1 │ ~/Studio/site-1 │ http://localhost:8881 │
├─────────────┼──────────────────────────┼────────────────────────────────────────┼─────────────────────────────────────────────────────┤
│ 🟢 Online │ site-2 │ ~/Studio/site-2 │ http://localhost:8882 │
└─────────────┴──────────────────────────┴────────────────────────────────────────┴─────────────────────────────────────────────────────┘
Stopping all:
gcsecsey@Mac-Studio studio % node dist/cli/main.js site stop --all
✔ Successfully stopped 2 sites
Running the stop --all command again:
gcsecsey@Mac-Studio studio % node dist/cli/main.js site stop --all
✔ No sites are currently running
Stopping a single site:
gcsecsey@Mac-Studio studio % node dist/cli/main.js site stop --path ~/Studio/site-2
✔ Successfully stopped 1 site
Checking the list:
gcsecsey@Mac-Studio studio % node dist/cli/main.js site list
✔ Found 2 sites
✔ Connected to process daemon
┌─────────────┬──────────────────────────┬────────────────────────────────────────┬─────────────────────────────────────────────────────┐
│ Status │ Name │ Path │ URL │
├─────────────┼──────────────────────────┼────────────────────────────────────────┼─────────────────────────────────────────────────────┤
│ 🔴 Offline │ site-1 │ ~/Studio/site-1 │ http://localhost:8881 │
├─────────────┼──────────────────────────┼────────────────────────────────────────┼─────────────────────────────────────────────────────┤
│ 🔴 Offline │ site-2 │ ~/Studio/site-2 │ http://localhost:8882 │
└─────────────┴──────────────────────────┴────────────────────────────────────────┴─────────────────────────────────────────────────────┘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
runCommandfunction instead ofrunCommandandrunCommandAllsite stop --allcommand from Studio codebase instead ofsite stop-allTesting Instructions
npm run cli:buildnode dist/cli/main.js site createto create at least two sitesnode dist/cli/main.js site stop --allnode dist/cli/main.js site stop --allNo sites are currently runningis displayednode dist/cli/main.js site stop --path PATH_TO_SITEnode dist/cli/main.js site listPre-merge Checklist