Hide footer on Skills/Instructions tabs and remove Installed badge#2926
Merged
Hide footer on Skills/Instructions tabs and remove Installed badge#2926
Conversation
The Edit Site modal footer (Cancel/Save) is only relevant for the General and Debugging tabs. Hide it when the Skills or Instructions tab is active. Also remove the InstalledBadge component from both panels since items in the "Installed" section are already visually grouped. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing a0a61b3 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Use taller content area (h-80) on Skills/Instructions tabs to fill the space left by the hidden footer, matching the overall modal height of the General/Debugging tabs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
katinthehatsite
approved these changes
Mar 27, 2026
Contributor
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
The changes look good to me, I am not seeing any regressions 👍
I personally preferred the badge but I guess it is a personal preference.
Should we also cleanup the <InstalledBadge /> component then? I am not seeing it used anywhere
1 task
Member
Author
Good catch! Removed it here a0a61b3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code generated the implementation. Changes were reviewed for correctness, and lint/typecheck/tests were verified before committing.
Proposed Changes
InstalledBadgecomponent from both the Skills and Instructions panels, as items in the "Installed" section are already visually grouped under the "Installed" headerTesting Instructions
npm startmodal-no-footer.mp4
Pre-merge Checklist