fix: prevent syndication loops through unique post identification #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation of loop prevention (PR #130) contained several bugs that prevented it from working correctly: **REST client issues:** - Used undefined variables `$key` and `$value` instead of `$meta_key` and `$meta_value`, causing PHP notices and failed lookups - Used `wp_remote_post()` instead of `wp_remote_get()` for retrieving posts - Missing URL encoding for meta parameters, breaking searches with special characters - Returned WP_Error object instead of boolean false on error - Included unnecessary Content-Type header for GET request **XML-RPC client issues:** - Retrieved all posts without filters, causing performance issues and timeouts on sites with many posts - Only checked first custom field (`[0]`), missing matches in other fields - Missing fields parameter in `wp.getPosts` call to ensure custom_fields are returned **Server class issues:** - Missing empty check for `$unique_id` before calling `is_source_site_post()`, potentially passing empty values - Typo in comment: "taget" instead of "target" These fixes ensure the loop prevention feature works as intended, preventing posts from being syndicated back to their source site.
Adds comprehensive unit test coverage for the is_source_site_post() method in both REST and XMLRPC clients. These tests validate the loop prevention logic that detects when a post being syndicated already exists on the target site, preventing duplicate content creation in circular syndication scenarios. The REST client test suite (19 tests) covers API interaction, URL encoding, authentication headers, and response handling. The XMLRPC client test suite (24 tests) additionally validates custom field iteration and type safety. Both suites use test doubles to isolate the method logic from WordPress dependencies whilst preserving the exact implementation for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents posts from being duplicated when syndication forms a loop (e.g., Site A syndicates to Site B, which then syndicates back to Site A).
How it works
post_uniqueidmeta) is generated for the postBug fixes
This PR includes fixes to the original implementation from #130:
$key/$value→$meta_key/$meta_value), changedwp_remote_posttowp_remote_get, added URL encoding, fixed return typeTest plan
post_uniqueidmetaFixes #127
Supersedes #130
Credit to @chetansatasiya for the original implementation.
🤖 Generated with Claude Code