fix: add validation before queuing auto-retry cron jobs #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a pull failure occurred, the auto-retry handler would schedule a cron job without validating the site data. This could cause problems when: 1. The syn_site post no longer exists (get_post returns null) 2. The post exists but is the wrong post type 3. The site has no valid syndication URL configured These conditions would cause the cron job to keep requeuing indefinitely whilst never being able to complete successfully. The fix adds three validation checks: - Verify the post exists and is a WP_Post instance - Verify the post type is syn_site - Verify the feed URL is a valid URL using filter_var Also refactored to use early returns for cleaner code flow and changed date() to gmdate() to address PHPCS timezone warnings. Fixes #101 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a pull failure occurred, the auto-retry handler would schedule a cron job without validating the site data. This caused problems when:
syn_sitepost no longer exists (get_post()returns null, causing fatal errors)These conditions would cause the cron job to keep requeuing indefinitely whilst never being able to complete successfully.
Solution
Added three validation checks to
handle_pull_failure_event():WP_Postinstancesyn_sitefilter_var()Also:
date()togmdate()to address PHPCS timezone warningsTest plan
Fixes #101
🤖 Generated with Claude Code