Pass the site_ID to the syn_rss_pull_filter_post filter#72
Closed
simonwheatley wants to merge 3 commits intodevelopfrom
Closed
Pass the site_ID to the syn_rss_pull_filter_post filter#72simonwheatley wants to merge 3 commits intodevelopfrom
simonwheatley wants to merge 3 commits intodevelopfrom
Conversation
2 tasks
Contributor
|
Superseded by #179 which applies this fix cleanly to the current codebase. The original branch had conflicts due to changes in the file structure over time. Thank you @simonwheatley for the original contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #71
I made the
site_idpropertyprotectedrather thanprivate, becauseprivatecauses issues if you ever need to extend the class and use those properties; but I'm happy to make itprivatefor consistency, if required.