Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Conversation

@rcrdortiz
Copy link
Contributor

@rcrdortiz rcrdortiz commented Jun 14, 2024

Changes proposed in this Pull Request:

Excluded some style variations that are not compatible with some Blockbase child themes. Now we can have Style Variations applied without needing to exclude the full list of style variations.

Related issue(s):

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Preview changes

I've detected changes to the following themes in this PR: Russell, Farrow, Otis, Meraki, Artly, Attar, Dorna, Appleton, Heiwa, Marl, Erma.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

@rcrdortiz rcrdortiz self-assigned this Jun 14, 2024
@rcrdortiz rcrdortiz requested a review from a team June 17, 2024 08:28
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Kerr's charcoal style variation needs disabling too. It's mentioned on Automattic/wp-calypso#78559 and the footer looks broken to me

Screenshot 2024-06-17 at 09 55 09

@rcrdortiz
Copy link
Contributor Author

I think Kerr's charcoal style variation needs disabling too. It's mentioned on Automattic/wp-calypso#78559 and the footer looks broken to me

Screenshot 2024-06-17 at 09 55 09

Kerr doesn't seem to be in the themes repo.

@dsas
Copy link
Contributor

dsas commented Jun 17, 2024

Kerr doesn't seem to be in the themes repo.

oops, didn't notice that it's a premium theme.

@mmtr
Copy link
Member

mmtr commented Jun 17, 2024

Can we also fix the themes with issues noted in #6996 (comment)?

Appleton (Charcoal: site title too dark, Ruby wine: Same as Default)
Dorna (Ruby wine: Same as Default)
Farrow (Charcoal: text too dark, Ruby wine: Same as Default)
Heiwa (Ruby wine: Same as Default)
Meraki (Ruby wine: Same as Default)
Russell (Charcoal: low contrast text)
Zoologist (White: Same as Default)

@rcrdortiz
Copy link
Contributor Author

rcrdortiz commented Jun 17, 2024

Can we also fix the themes with issues noted in #6996 (comment)?

Appleton (Charcoal: site title too dark, Ruby wine: Same as Default)
Dorna (Ruby wine: Same as Default)
Farrow (Charcoal: text too dark, Ruby wine: Same as Default)
Heiwa (Ruby wine: Same as Default)
Meraki (Ruby wine: Same as Default)
Russell (Charcoal: low contrast text)
Zoologist (White: Same as Default)

Sure, I just added it to the list of related issues.

Fixing Zoologist is OOS (the problem isn't a side effect of propagating base theme style variations), it doesn't extend a base theme. The White variation is defined inside the Zoologist theme folder.

@rcrdortiz rcrdortiz merged commit 2dc712e into trunk Jun 17, 2024
@rcrdortiz rcrdortiz deleted the fix/blockbase-children-style-variations branch June 17, 2024 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants