fix(dev-env): do not show the update prompt when stdin is not a TTY#2241
Merged
rinatkhaziev merged 1 commit intotrunkfrom Feb 19, 2025
Merged
fix(dev-env): do not show the update prompt when stdin is not a TTY#2241rinatkhaziev merged 1 commit intotrunkfrom
rinatkhaziev merged 1 commit intotrunkfrom
Conversation
sjinks
force-pushed
the
fix/update-prompt
branch
from
8edba11 to
c26b057
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
|
rinatkhaziev
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
vip dev-env start < /dev/null, if you happen not to have the latest version of WordPress, VIP CLI will crash on the "Would you like to upgrade WordPress?" prompt because the input is not a TTY.This PR fixes that.
Pull request checklist
New release checklist
Steps to Test
VIP CLI will crash without this patch and start the environment with it.