fix: MCCY settings confirmation dialog #10933
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -1.06 MB (-87%) 🏆 Total Size: 162 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5178
Changes proposed in this Pull Request
Using this selector to ensure that the unload event doesn't get triggered on the MCCY settings page: https://github.com/woocommerce/woocommerce/blob/1a5c8d69e8447fc1a0cff1333b1bdaa8a419f218/plugins/woocommerce/client/legacy/js/admin/settings.js#L108
One of the main problems is with the MCCY settings page implementation: it doesn't use a router to change URL path, so the unload event is not triggered when navigating away from an edited single currency view.
If the customer navigates to the currency list, the dialog is triggered. Which is inaccurate.
With these changes, I am modifying the implementation to never show the dialog, which is triggered by WC Core.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge