-
Notifications
You must be signed in to change notification settings - Fork 72
Show Activate payments notice in WooPayments Settings only for test accounts #10978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Activate payments notice in WooPayments Settings only for test accounts #10978
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 868 kB ℹ️ View Unchanged
|
@mordeth can we get this finished? It would have been great to have it in 9.8.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions check out! Great work on this 🙏
Fixes WOOPMNT-5223
Changes proposed in this Pull Request
This PR fixes an issue where the “Activate Payments” notice was incorrectly displayed for live accounts with test mode enabled. Now, the notice with the “Activate Payments” button appears only when the connected account is a test account with dev mode disabled, preventing misleading activation messages for live accounts. In other cases, a Development Mode notice is shown to guide users on activating live payments.
Additionally, when a sandbox account is connected, a notice is displayed to clearly inform merchants that the current account is not live. If dev mode is enabled, the Development Mode notice is shown instead.
Prerequisites
Testing instructions
Navigate to WCPay Dev and disable 'dev mode'.
Navigate to Payments > Settings and verify the Activate Payments notice is displayed on top.
Navigate to WCPay Dev and enable 'dev mode'.
Navigate to WooCommerce > Home and Click on the "Activate Payments" task and proceed with account onboarding until fully onboarded. Close the modal and verify a test account is onboarded.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge