-
Notifications
You must be signed in to change notification settings - Fork 72
[E2E] Re-enable Woocommerce Blocks e2e tests #11005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/woopmnt-5249-e2e-ensure-version-coverage-for-woocommerce-and-php
Are you sure you want to change the base?
Conversation
…names for clarity
…r different WooCommerce versions
…WooCommerce versions
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 868 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables WooCommerce Blocks e2e tests that were previously disabled, implementing a selective testing strategy based on WC version compatibility.
- Re-enables blocks tests for newer WC versions (latest, beta, RC) while skipping them for older versions
- Updates test matrix configuration to include blocks tests where appropriate
- Cleans up commented-out test configuration code
…tests strategy for WooCommerce versions
…1 WooCommerce version and refine comments for clarity
c1d8954
to
a40a983
Compare
7dce5fd
to
7140523
Compare
a7d7bee
to
c40d544
Compare
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see https://github.com/Automattic/woocommerce-payments/actions/runs/16942260738 is running very well for this branch/PR.
There are a few things:
-
I think we can improve a bit and remove the need of introducing a new variable
skip_blocks
. See more in my inline comment. -
Manually run this branch for
.github/workflows/e2e-pull-request.yml
to see if there is any issue?
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
62527e5
to
0712bdf
Compare
…ion-coverage-for-woocommerce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
…merce-and-php' into dev/woopmnt-5251-e2e-investigate-and-re-enable-woocommerce-blocks-e2e-tests
Fixes #WOOPMNT-5251
Re-enables WooCommerce blocks e2e tests that were previously disabled.
Changes proposed in this Pull Request
TEST_GROUPS_BLOCKS="blocks"
and included blocks tests in matrixTest Strategy
skip_blocks=1
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge