-
Notifications
You must be signed in to change notification settings - Fork 73
Add Avatax compatibility filters for Express Checkout #11204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Avatax compatibility filters for Express Checkout #11204
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 930 kB ℹ️ View Unchanged
|
rtio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work around seems fine, but I would like to move it to its own file, to make it explicit this is something just for this plugin.
|
Thanks for the review @rtio, I moved the code to its own file. I'm figuring out how to set up my local to test it. |
…-do-not-show-tax-on-orders-as-a
…-do-not-show-tax-on-orders-as-a
|
Closing since the bug cannot be reproduced with version 3.6.2 of the Avatax plugin and can be solved with an upgrade. |
Fixes #
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge