-
Notifications
You must be signed in to change notification settings - Fork 73
feat: add amazon pay settings storage #11228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
10a6225 to
79a2190
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +391 B (0%) Total Size: 930 kB
ℹ️ View Unchanged
|
28b1e83 to
63e8030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
client/settings/express-checkout-settings/express-checkout-settings-notices.tsx
Outdated
Show resolved
Hide resolved
mgascam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I followed the instructions and everything worked as expected. The options persist after a page reload, and the Amazon Pay locations behave independently. Thanks for adding the ExpressCheckoutSettingsNotices component, very nice touch.
Fixes WOOPMNT-5609
Changes proposed in this Pull Request
Adding settings storage (enablement status and location preferences) for Amazon Pay.
While testing, I noticed there was a notice in Google Pay/Apple Pay and Amazon Pay alerting the merchant that changing the setting would have affected other payment methods.
I extracted that notice and adopted it for Amazon Pay.
The settings are only persisted in the DB. Amazon Pay is not yet implemented in customer-facing pages, so you can't test it or preview it, yet.
Testing instructions
wp option update _wcpay_feature_amazon_pay 0)wp option update _wcpay_feature_amazon_pay 1)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge