Tests: Make sure test data gets deleted properly (#1543)

* Tests: Make sure users get deleted after creating them

* Add missing tear_down_after_class calls

* Revert "Tests: Make sure users get deleted after creating them"

This reverts commit 27142a4.

* Don't delete data manually.

`tear_down_after_class` does a better job out of the box.

Author: obenland

tests/includes/class-test-migration.php

@@ -90,21 +90,6 @@ public static function set_up_before_class() {
 		\add_comment_meta( self::$fixtures['comment'], 'activitypub_status', 'federated' );
 	}
 
-	/**
-	 * Tear down the test.
-	 */
-	public static function tear_down_after_class() {
-		// Clean up posts.
-		foreach ( self::$fixtures['posts'] as $post_id ) {
-			\wp_delete_post( $post_id, true );
-		}
-
-		// Clean up comment.
-		if ( isset( self::$fixtures['comment'] ) ) {
-			\wp_delete_comment( self::$fixtures['comment'], true );
-		}
-	}
-
 	/**
 	 * Tear down the test.
 	 */

tests/includes/class-test-move.php

@@ -31,13 +31,6 @@ public static function set_up_before_class() {
 		self::$user_id = self::factory()->user->create( array( 'role' => 'author' ) );
 	}
 
-	/**
-	 * Clean up after tests.
-	 */
-	public static function tear_down_after_class() {
-		wp_delete_user( self::$user_id );
-	}
-
 	/**
 	 * Test the account() method with valid input.
 	 *

tests/includes/handler/class-test-delete.php

@@ -31,15 +31,6 @@ public static function set_up_before_class() {
 		self::$user_id = self::factory()->user->create( array( 'role' => 'author' ) );
 	}
 
-	/**
-	 * Clean up after tests.
-	 */
-	public static function tear_down_after_class() {
-		wp_delete_user( self::$user_id );
-
-		parent::tear_down_after_class();
-	}
-
 	/**
 	 * Set up the test.
 	 */

tests/includes/rest/class-test-actors-inbox-controller.php

@@ -43,13 +43,6 @@ public static function set_up_before_class() {
 		);
 	}
 
-	/**
-	 * Clean up after tests.
-	 */
-	public static function tear_down_after_class() {
-		wp_delete_user( self::$user_id );
-	}
-
 	/**
 	 * Set up the test.
 	 */

tests/includes/rest/class-test-collections-controller.php

@@ -52,21 +52,6 @@ public static function set_up_before_class() {
 		self::factory()->term->add_post_terms( self::$post_id, self::$tag_ids, 'post_tag' );
 	}
 
-
-	/**
-	 * Tear down.
-	 */
-	public static function tear_down_after_class() {
-		\wp_delete_user( self::$user_id );
-
-		foreach ( self::$tag_ids as $tag_id ) {
-			\wp_delete_term( $tag_id, 'post_tag' );
-		}
-
-		parent::tear_down_after_class();
-	}
-
-
 	/**
 	 * Test registration of routes.
 	 *

tests/includes/rest/class-test-comments-controller.php

@@ -52,19 +52,6 @@ public static function set_up_before_class() {
 		add_comment_meta( self::$comment_ids[0], 'protocol', 'activitypub', true );
 	}
 
-	/**
-	 * Tear down.
-	 */
-	public static function tear_down_after_class() {
-		\wp_delete_user( self::$user_id );
-
-		foreach ( self::$comment_ids as $comment_id ) {
-			\wp_delete_comment( $comment_id );
-		}
-
-		parent::tear_down_after_class();
-	}
-
 	/**
 	 * Set up the test case.
 	 */

tests/includes/rest/class-test-replies-controller.php

@@ -71,20 +71,6 @@ public static function set_up_before_class() {
 		self::$comment_ids = array( $comment_1, $comment_2 );
 	}
 
-	/**
-	 * Tear down.
-	 */
-	public static function tear_down_after_class() {
-		foreach ( self::$comment_ids as $comment_id ) {
-			\wp_delete_comment( $comment_id, true );
-		}
-
-		\wp_delete_post( self::$post_id, true );
-		\wp_delete_user( self::$user_id );
-
-		parent::tear_down_after_class();
-	}
-
 	/**
 	 * Test registration of routes.
 	 *