Made it a bit more explanatory and easier to understand for beginners #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfefferle
requested changes
Sep 14, 2025
| "decentralized", | ||
| "social-network" | ||
| ], | ||
| "homepage": "https://github.com/pfefferle/wordpress-activitypub", |
There was a problem hiding this comment.
The main repo is this one now.
Suggested change
| "homepage": "https://github.com/pfefferle/wordpress-activitypub", | |
| "homepage": "https://github.com/Automattic/wordpress-activitypub", |
Comment on lines
+23
to
+25
| "issues": "https://github.com/pfefferle/wordpress-activitypub/issues", | ||
| "source": "https://github.com/pfefferle/wordpress-activitypub", | ||
| "docs": "https://github.com/pfefferle/wordpress-activitypub/wiki" |
There was a problem hiding this comment.
Suggested change
| "issues": "https://github.com/pfefferle/wordpress-activitypub/issues", | |
| "source": "https://github.com/pfefferle/wordpress-activitypub", | |
| "docs": "https://github.com/pfefferle/wordpress-activitypub/wiki" | |
| "issues": "https://github.com/Automattic/wordpress-activitypub/issues", | |
| "source": "https://github.com/Automattic/wordpress-activitypub", | |
| "docs": "https://github.com/Automattic/wordpress-activitypub/tree/trunk/docs" |
| "require": { | ||
| "php": ">=7.2", | ||
| "composer/installers": "^1.0 || ^2.0" | ||
| "php": ">=7.4", |
There was a problem hiding this comment.
Please keep 7.2
Suggested change
| "php": ">=7.4", | |
| "php": ">=7.2", |
| "require-dev": { | ||
| "automattic/jetpack-changelogger": "6.0.0", | ||
| "phpunit/phpunit": "^8 || ^9", | ||
| "php": ">=7.4", |
There was a problem hiding this comment.
Please keep 7.2
Suggested change
| "php": ">=7.4", | |
| "php": ">=7.2", |
Comment on lines
-38
to
+80
| "changes-dir": ".github/changelog/", | ||
| "link-template": "https://github.com/Automattic/wordpress-activitypub/compare/${old}...${new}" | ||
| "changes-dir": ".changelog/", | ||
| "link-template": "https://github.com/pfefferle/wordpress-activitypub/compare/${old}...${new}" |
There was a problem hiding this comment.
Please do not change... This is needed exactly as it is!
Comment on lines
+63
to
+69
| "autoload": { | ||
| "psr-4": { | ||
| "ActivityPub\\": "includes/" | ||
| }, | ||
| "files": [ | ||
| "includes/functions.php" | ||
| ] |
There was a problem hiding this comment.
please do not add an autoloader, the plugin comes with it's own autoloader!
| "authors": [ | ||
| { | ||
| "name": "Matthias Pfefferle", | ||
| "email": "[email protected]", |
There was a problem hiding this comment.
Please remove my email
Suggested change
| "email": "[email protected]", |
Comment on lines
+15
to
+20
| { | ||
| "name": "Matthias Pfefferle", | ||
| "email": "[email protected]", | ||
| "homepage": "https://notiz.blog", | ||
| "role": "Lead Developer" | ||
| } |
There was a problem hiding this comment.
If we add authors, we should add Konstantin and Automattic!
Suggested change
| { | |
| "name": "Matthias Pfefferle", | |
| "email": "[email protected]", | |
| "homepage": "https://notiz.blog", | |
| "role": "Lead Developer" | |
| } | |
| { | |
| "name": "Automattic", | |
| "homepage": "https://automattic.com", | |
| "role": "Developer" | |
| }, | |
| { | |
| "name": "Matthias Pfefferle", | |
| "homepage": "https://notiz.blog", | |
| "role": "Developer" | |
| }, | |
| { | |
| "name": "Konstantin Obenland", | |
| "homepage": "https://obenland.it", | |
| "role": "Developer" | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message