Skip to content

Clarify striptags usage in code review feedback#2486

Closed
Copilot wants to merge 1 commit intoremove/handle-namingfrom
copilot/sub-pr-2485
Closed

Clarify striptags usage in code review feedback#2486
Copilot wants to merge 1 commit intoremove/handle-namingfrom
copilot/sub-pr-2485

Conversation

Copy link

Copilot AI commented Nov 18, 2025

The PR reviewer (@pfefferle) referenced a striptags suggestion from a previous code review that failed to complete. The context is unclear since:

  1. The automated code review encountered an error and did not produce review comments
  2. This PR specifically addresses function renaming (removing "handle" prefix from event handlers)
  3. The striptags reference likely pertains to __unstableStripHTML usage in src/social-web/components/fields/{excerpt,content}/index.tsx, which predates this PR

Current Implementation:

import { __unstableStripHTML as stripHTML } from '@wordpress/dom';

const getPlainTextExcerpt = ( item: FeedPost ): string => {
  const text = item.excerpt?.rendered || item.content?.rendered || '';
  return decodeEntities( stripHTML( text ) );
};

Action Taken:
Requested clarification on whether to replace __unstableStripHTML with the striptags npm package, or if the comment refers to a different aspect of the code.

No code changes made pending clarification, as the request is orthogonal to this PR's scope (function renaming).


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove generic 'handle' prefix from Social Web UI function names Clarify striptags usage in code review feedback Nov 18, 2025
Copilot AI requested a review from pfefferle November 18, 2025 07:24
@pfefferle
Copy link
Member

I am not sure what you are doing here!? There are no changes in this PR!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants