Fix PHP 8.4+ deprecation warning for str_getcsv()#2622
Merged
Conversation
Explicitly pass the escape parameter to str_getcsv() to avoid the deprecation warning in PHP 8.4+ while maintaining compatibility with PHP 7.2+.
obenland
added
the
Skip Changelog
There was a problem hiding this comment.
Pull request overview
This PR addresses PHP 8.4+ deprecation warnings by explicitly specifying all parameters for str_getcsv() calls in the Blocklist Subscriptions class. The changes ensure forward compatibility while maintaining backward compatibility with PHP 7.2+.
Key Changes:
- Added explicit separator, enclosure, and escape parameters to two
str_getcsv()calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2590.
Fixes PHP 8.4+ deprecation warnings for
str_getcsv()in the Blocklist Subscriptions class.In PHP 8.4+, the
$escapeparameter must be explicitly provided as its default value is changing from"\\"to"". This PR explicitly passes all parameters to maintain the current behavior while avoiding the deprecation notice.Changes
str_getcsv()calls inBlocklist_Subscriptions::parse_csv_string()Testing