Merged
Conversation
Replace "A curated list of the worst actors on the fediverse" with clearer wording that describes what to do with the list rather than characterizing the actors. Links IFTAS to their website. Follow-up to #2590.
obenland
added
the
Skip Changelog
obenland
added
the
Skip Changelog
pfefferle
approved these changes
Dec 16, 2025
There was a problem hiding this comment.
Pull request overview
This PR updates the description text for the IFTAS DNI List subscription in the ActivityPub moderation settings to use more neutral, action-focused language. Instead of characterizing actors as "the worst," it now describes what the list contains (domains not recommended for federation) and adds a link to the IFTAS organization website.
- Replaces subjective language with objective, action-focused description
- Adds hyperlink to IFTAS website for users to learn more about the organization
- Changes output function from
esc_html_e()towp_kses_post()with__()to allow HTML content
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <?php \esc_html_e( 'Subscribe to IFTAS DNI List', 'activitypub' ); ?> | ||
| </button> | ||
| <?php \esc_html_e( 'A curated list of the worst actors on the fediverse.', 'activitypub' ); ?> | ||
| <?php echo \wp_kses_post( \__( 'Domains <a href="https://about.iftas.org/" target="_blank" rel="noopener">IFTAS</a> recommends not federating with.', 'activitypub' ) ); ?> |
There was a problem hiding this comment.
The link opens in a new tab but lacks screen reader context. Consider adding aria-label or visible text indicating the link opens externally, such as '(opens in new tab)' or using an icon with appropriate alt text.
Suggested change
| <?php echo \wp_kses_post( \__( 'Domains <a href="https://about.iftas.org/" target="_blank" rel="noopener">IFTAS</a> recommends not federating with.', 'activitypub' ) ); ?> | |
| <?php echo \wp_kses_post( \__( 'Domains <a href="https://about.iftas.org/" target="_blank" rel="noopener">IFTAS</a> recommends not federating with. (opens in new tab)', 'activitypub' ) ); ?> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the description "A curated list of the worst actors on the fediverse" with clearer wording that focuses on the action (blocking) rather than characterizing the actors.
Before: "A curated list of the worst actors on the fediverse."
After: "Domains IFTAS recommends not federating with." (with IFTAS linked to their website)
Testing Instructions
Follow-up to
#2590