-
Notifications
You must be signed in to change notification settings - Fork 2k
A4A: Update KB article links to view articles via the Help center. #107829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1120 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
yashwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected.
However, I left some comments. Please let me know your thoughts.
| ></a> | ||
| ), | ||
| // eslint-disable-next-line jsx-a11y/anchor-is-valid | ||
| a: <a onClick={ onLearnMoreClick } href="#" />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a Button here?
<Button onClick={ onLearnMoreClick } variant="link">
{ translate( 'Learn more.' ) }
</Button>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| onClick={ () => | ||
| showSupportGuide( | ||
| 'https://agencieshelp.automattic.com/knowledge-base/the-automattic-for-agencies-client-plugin/' | ||
| ) | ||
| } | ||
| href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. I think we can use a Button.
| onClick={ () => { | ||
| dispatch( recordTracksEvent( 'calypso_a4a_migrations_payout_kb_link_click' ) ); | ||
| showSupportGuide( | ||
| 'https://agencieshelp.automattic.com/knowledge-base/automattic-for-agencies-earnings/' | ||
| ); | ||
| } } | ||
| href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as my comment above. Let's leave this as is until we refactor all our links to use the core component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Could we please start a conversation with the design and see how we can address this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure. I can discuss this with @madebynoam later.
a2ba9e8 to
ede1070
Compare
|
@yashwin thanks for the review! 🙏 I've addressed one of your comment can you have another look? |
yashwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ede1070 to
62dfc72
Compare
|
Translation for this Pull Request has now been finished. |
…107829) * Create a helper function for showing support guide. * Update KB article links to use Help center. * Remove all arrow keys.

Related to https://linear.app/a8c/issue/A4A-1942/fix-a4a-dashboard-links-to-help-center-docs
NOTE: This is not an exhaustive list and only some of the links are updated. Those will be addressed on follow-up PRs.
Proposed Changes
This pull request refactors how external Knowledge Base (KB) links are handled across the Automattic for Agencies frontend. Instead of opening KB articles in a new tab, clicking these links now opens the relevant article directly in the in-app Help Center modal, providing a more integrated user experience. This change is implemented consistently across multiple components and sections by introducing and utilizing a new
showSupportGuidemethod from theuseHelpCenterhook.Help Center Integration and Link Handling:
showSupportGuidemethod in theuseHelpCenterhook, enabling programmatic navigation to specific KB articles within the Help Center modal. (client/a8c-for-agencies/hooks/use-help-center.ts) [1] [2]showSupportGuidefor KB article links, replacing direct external links with in-app modal navigation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27]User Experience Improvements:
Code Consistency and Cleanup:
href,target, andrelattributes from KB anchor tags and buttons, and replaced them with click handlers that trigger the Help Center modal. [1] [2] [3] [4] [5] [6] [7] [8] [9]useHelpCenterhook where necessary. [1] [2] [3] [4] [5] [6] [7] [8] [9]These changes collectively modernize the way help content is presented, keeping users within the application context and offering a more seamless support experience.
Why are these changes being made?
Testing Instructions
/overviewpage.Pre-merge Checklist