Skip to content

Conversation

@arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Dec 25, 2025

Part of DOTMSD-976

Proposed Changes

  • Align the actions with v2, especially for the "Restore site" to open the modal
  • Align the name and URL field with v2
Before After
image image

Why are these changes being made?

  • UI consistency

Testing Instructions

  • Go to /sites on Calypso Live link
  • Select any site
  • Ensure the name and URL of the list view are aligned with the Sites list
  • Ensure you cannot switch the layout
  • Click ... to see actions
  • Ensure the actions are aligned with the Sites list

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Dec 25, 2025
@arthur791004 arthur791004 requested a review from a team December 25, 2025 05:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 25, 2025
@arthur791004 arthur791004 marked this pull request as ready for review December 25, 2025 05:52
@matticbot
Copy link
Contributor

matticbot commented Dec 25, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/unify-old-site-list on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 25, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~292 bytes added 📈 [gzipped])

Details
name                    parsed_size           gzip_size
entry-reauth-required        +711 B  (+0.0%)     +285 B  (+0.0%)
entry-main                   +711 B  (+0.0%)     +292 B  (+0.0%)
entry-login                  +711 B  (+0.0%)     +285 B  (+0.0%)
entry-subscriptions          +111 B  (+0.0%)      +22 B  (+0.0%)
entry-stepper                +111 B  (+0.0%)      +22 B  (+0.0%)
entry-domains-landing        +111 B  (+0.0%)      +22 B  (+0.0%)
entry-dashboard-dotcom       +111 B  (+0.0%)      +22 B  (+0.0%)
entry-dashboard-ciab         +111 B  (+0.0%)      +22 B  (+0.0%)
entry-browsehappy            +111 B  (+0.0%)      +22 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2334 bytes removed 📉 [gzipped])

Details
name                               parsed_size           gzip_size
staging-site                           -8004 B  (-0.3%)    -2094 B  (-0.3%)
site-logs                              -8004 B  (-0.3%)    -2094 B  (-0.3%)
hosting                                -8004 B  (-0.2%)    -2094 B  (-0.3%)
github-deployments                     -8004 B  (-0.2%)    -2095 B  (-0.3%)
sites-dashboard                        -7991 B  (-0.2%)    -2094 B  (-0.2%)
site-settings                          -7991 B  (-0.2%)    -2091 B  (-0.3%)
site-performance                       -7991 B  (-0.2%)    -2169 B  (-0.3%)
site-monitoring                        -7991 B  (-0.3%)    -2094 B  (-0.3%)
plans                                  -7991 B  (-0.2%)    -2095 B  (-0.2%)
overview                               -7433 B  (-0.2%)    -2027 B  (-0.2%)
domains                                -7433 B  (-0.2%)    -2027 B  (-0.2%)
woocommerce-installation                -161 B  (-0.0%)      +11 B  (+0.0%)
woocommerce                             -161 B  (-0.0%)      +11 B  (+0.0%)
themes                                  -161 B  (-0.0%)      +11 B  (+0.0%)
theme                                   -161 B  (-0.0%)      +11 B  (+0.0%)
subscribers                             -161 B  (-0.0%)      +11 B  (+0.0%)
stats                                   -161 B  (-0.0%)      +11 B  (+0.0%)
site-purchases                          -161 B  (-0.0%)      +11 B  (+0.0%)
settings-writing                        -161 B  (-0.0%)      +11 B  (+0.0%)
settings-security                       -161 B  (-0.0%)      +11 B  (+0.0%)
settings-reading                        -161 B  (-0.0%)      +11 B  (+0.0%)
settings-podcast                        -161 B  (-0.0%)      +11 B  (+0.0%)
settings-performance                    -161 B  (-0.0%)      +11 B  (+0.0%)
settings-newsletter                     -161 B  (-0.0%)      +11 B  (+0.0%)
settings-jetpack                        -161 B  (-0.0%)      +11 B  (+0.0%)
settings-discussion                     -161 B  (-0.0%)      +11 B  (+0.0%)
settings                                -161 B  (-0.0%)      +11 B  (+0.0%)
scan                                    -161 B  (-0.0%)      +11 B  (+0.0%)
reader                                  -161 B  (-0.0%)      +11 B  (+0.0%)
purchases                               -161 B  (-0.0%)      +11 B  (+0.0%)
promote-post-i2                         -161 B  (-0.0%)      +11 B  (+0.0%)
posts-custom                            -161 B  (-0.0%)      +11 B  (+0.0%)
posts                                   -161 B  (-0.0%)      +11 B  (+0.0%)
plugins                                 -161 B  (-0.0%)      +11 B  (+0.0%)
people                                  -161 B  (-0.0%)      +11 B  (+0.0%)
pages                                   -161 B  (-0.0%)      +11 B  (+0.0%)
notification-settings                   -161 B  (-0.0%)     +103 B  (+0.0%)
migrate                                 -161 B  (-0.0%)      +11 B  (+0.0%)
media                                   -161 B  (-0.0%)      +11 B  (+0.0%)
marketplace                             -161 B  (-0.0%)      +11 B  (+0.0%)
marketing                               -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-social                          -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-search                          -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-connect                         -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-settings                  -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-pricing                   -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-plugin-management         -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-partner-portal            -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-overview                  -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-features-comparison       -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud-agency-dashboard          -161 B  (-0.0%)      +11 B  (+0.0%)
jetpack-cloud                           -161 B  (-0.0%)      +11 B  (+0.0%)
import                                  -161 B  (-0.0%)      +11 B  (+0.0%)
home                                    -161 B  (-0.0%)      +11 B  (+0.0%)
gutenberg-editor                        -161 B  (-0.0%)      +11 B  (+0.0%)
google-my-business                      -161 B  (-0.0%)      +11 B  (+0.0%)
export                                  -161 B  (-0.0%)      +11 B  (+0.0%)
email                                   -161 B  (-0.0%)      +11 B  (+0.0%)
earn                                    -161 B  (-0.0%)      +11 B  (+0.0%)
customize                               -161 B  (-0.0%)      +11 B  (+0.0%)
concierge                               -161 B  (-0.0%)      +11 B  (+0.0%)
comments                                -161 B  (-0.0%)      +11 B  (+0.0%)
checkout                                -161 B  (-0.0%)      +11 B  (+0.0%)
backup                                  -161 B  (-0.0%)      +11 B  (+0.0%)
add-ons                                 -161 B  (-0.0%)      +11 B  (+0.0%)
activity                                -161 B  (-0.0%)      +11 B  (+0.0%)
account                                 -161 B  (-0.0%)      +11 B  (+0.0%)
a8c-for-agencies-sites                  -161 B  (-0.0%)      +11 B  (+0.0%)
a8c-for-agencies-plugins                -161 B  (-0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1223 bytes added 📈 [gzipped])

Details
name                                                                              parsed_size           gzip_size
async-load-calypso-sites-settings-administration-tools-restore-site-restore-s...      +2243 B    (new)    +1024 B    (new)
async-load-signup-steps-hosting-decider                                                +587 B  (+1.2%)     +230 B  (+1.4%)
async-load-design                                                                      -474 B  (-0.0%)      -42 B  (-0.0%)
async-load-design-playground                                                           -229 B  (-0.0%)      -34 B  (-0.0%)
async-load-signup-steps-site-picker                                                    -161 B  (-0.1%)      +11 B  (+0.0%)
async-load-signup-steps-difm-site-picker                                               -161 B  (-0.1%)      +11 B  (+0.0%)
async-load-design-blocks                                                               -161 B  (-0.0%)      +11 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 added the Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. label Dec 26, 2025
@arthur791004 arthur791004 force-pushed the feat/unify-old-site-list branch from 0fd599b to ca63014 Compare December 26, 2025 08:09
@arthur791004 arthur791004 force-pushed the feat/unify-old-site-list branch from ca63014 to 7e826ac Compare January 2, 2026 02:55
@arthur791004 arthur791004 requested review from a team and removed request for a team January 5, 2026 02:35
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Nice improvements 👍 Though I think I never use the actions since the site is already open in the right side panel 😂

@arthur791004 arthur791004 merged commit 1c520f6 into trunk Jan 5, 2026
12 checks passed
@arthur791004 arthur791004 deleted the feat/unify-old-site-list branch January 5, 2026 05:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 5, 2026
heydemoura pushed a commit that referenced this pull request Jan 18, 2026
)

* Dashboard v1: Make actions consistent with v2

* Dashboard v1: Make name and URL field consistent with v2

* Dashboard v1: Disable layout switcher on sites dataviews

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants