Skip to content

FSE: Update calypso-build to latest 4.2.1 #37058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2019
Merged

FSE: Update calypso-build to latest 4.2.1 #37058

merged 2 commits into from
Oct 28, 2019

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Oct 25, 2019

Update FSE calypso-build to latest version. Required for #37031.

Testing

  • Make sure the FSE build and output continues to work as expected.

@sirreal sirreal added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Packages labels Oct 25, 2019
@sirreal sirreal requested review from a team October 25, 2019 06:39
@sirreal sirreal requested a review from a team as a code owner October 25, 2019 06:39
@matticbot
Copy link
Contributor

matticbot commented Oct 25, 2019

Test live: https://calypso.live/?branch=update/fse-calypso-build

@matticbot
Copy link
Contributor

matticbot commented Oct 25, 2019

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal changed the title Update calypso-build to latest 4.2.0 FSE: Update calypso-build to latest 4.2.0 Oct 25, 2019
@sirreal sirreal changed the title FSE: Update calypso-build to latest 4.2.0 FSE: Update calypso-build to latest 4.2.1 Oct 25, 2019
@sirreal
Copy link
Member Author

sirreal commented Oct 25, 2019

Needs another publish of calypso-build. 4.2.0 is broken.

@sirreal sirreal force-pushed the update/fse-calypso-build branch from fce2c13 to 5129353 Compare October 25, 2019 08:28
@sirreal
Copy link
Member Author

sirreal commented Oct 25, 2019

Tests are passing, this seems to be working and would remove a blocker for the Node v12 upgrade.

@sirreal sirreal mentioned this pull request Oct 25, 2019
Merged
2 tasks
@gwwar
Copy link
Contributor

gwwar commented Oct 25, 2019

Dist artifacts in https://circleci.com/gh/Automattic/wp-calypso/474712#artifacts/containers/0 look okay at a glance. I'll take a quick spin on the sandbox.

gwwar
gwwar approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirreal!

I think this tests about the same. Giving approval here, but let's get a +1 on behavior from Cylon so folks aren't surprised on the next attempted update. cc @vindl or @noahtallen if you happen to be online

noahtallen
noahtallen approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev and prod builds seem to be working fine for me locally with this change :)

@sirreal sirreal added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 28, 2019
@sirreal
Copy link
Member Author

sirreal commented Oct 28, 2019

Thanks for help testing! 🙇

@sirreal sirreal merged commit eef2a56 into master Oct 28, 2019
@sirreal sirreal deleted the update/fse-calypso-build branch October 28, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gwwar gwwar gwwar approved these changes

@noahtallen noahtallen noahtallen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Framework Packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sirreal @matticbot @gwwar @noahtallen