Skip to content

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Nov 4, 2019

Node v12 is now LTS. Use it.

Reverts #37298

@sirreal sirreal requested review from a team as code owners November 4, 2019 09:44
@matticbot
Copy link
Contributor

1 similar comment
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Nov 4, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~44111 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding      +186966 B  (+7.5%)   +44114 B  (+6.8%)
entry-main                   -93 B  (-0.0%)       +0 B
entry-login                  -93 B  (-0.0%)       -1 B  (-0.0%)
entry-domains-landing        -93 B  (-0.0%)       -2 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~8 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor        +78 B  (+0.0%)      +21 B  (+0.0%)
woocommerce             -18 B  (-0.0%)      -13 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~340 bytes removed 📉 [gzipped])

name                                 parsed_size           gzip_size
async-load-lib-happychat-connection       +222 B  (+0.3%)     -340 B  (-1.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 4, 2019
@sirreal
Copy link
Member Author

sirreal commented Nov 7, 2019

I think the conclusion of investigation is that we should just try this again. @Automattic/team-calypso y'all approve?

@blowery
Copy link
Contributor

blowery commented Nov 7, 2019

@sirreal yup, give it another shot

@sirreal sirreal force-pushed the revert-37298-revert-37031-update/node-lts-12 branch from 80899d9 to 3ee5ccf Compare November 11, 2019 09:56
@sirreal sirreal merged commit 9d815e7 into master Nov 11, 2019
@sirreal sirreal deleted the revert-37298-revert-37031-update/node-lts-12 branch November 11, 2019 10:10
@sirreal sirreal removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge labels Nov 11, 2019
sirreal added a commit that referenced this pull request Nov 11, 2019
sirreal added a commit that referenced this pull request Nov 11, 2019
sirreal added a commit that referenced this pull request Nov 11, 2019
blowery pushed a commit that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants