Open
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
ping @dd32 @GaryJones |
dd32
reviewed
Aug 1, 2024
Member
dd32
left a comment
dd32
left a comment
There was a problem hiding this comment.
Reading the changes here, I don't see any issues with it, other than a few minor coding style notes.
I think it's worth noting that it also looks like a Unix socket would continue working if it's added as such, which while undocumented, technically would work.
$memcached_servers = array(
'default' => array(
'/path/to/socket:0'
}
);
ton31337
force-pushed
the
fix/ipv6_support_for_memcached
branch
2 times, most recently
from
32d0eb5 to
1e33e66
Compare
Add Hostinger we run memcached on ::1 (IPv6-only), and noticed, that it do not work. Let's get fix it. Signed-off-by: Donatas Abraitis <donatas.abraitis@hostinger.com>
ton31337
force-pushed
the
fix/ipv6_support_for_memcached
branch
from
1e33e66 to
625d68e
Compare
Author
|
Thanks for a quick review, I fixed the suggested changes. Also rebased and force-pushed. |
dd32
approved these changes
Aug 1, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.